This repository was archived by the owner on May 31, 2021. It is now read-only.
Change to activate virtualenv in getting_started #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is not the topic of this doc to explain how to use a virtualenv, I fear that beginners will have issues when trying the examples as the virtual environment will not be loaded and they will think to use `./venv/bin/python` for launching every example.
getting_started.rst
Outdated
| Activate the virtual environment and install ``aiohttp`` inside: | ||
|
|
||
| ./venv/bin/python -m pip install -U aiohttp | ||
| source ./venv/bin/activate |
There was a problem hiding this comment.
Can please replace ./venv with venv? The "./" part is useless and longer to type :-)
(It's not directly related to your change.)
|
I shut down the project: #33 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is not the topic of this doc to explain how to use a virtualenv, I fear that beginners will have issues when trying the examples as the virtual environment will not be loaded and they will think to use
./venv/bin/pythonfor launching every example.